diff --git a/src/lint/engine/ArcanistLintEngine.php b/src/lint/engine/ArcanistLintEngine.php index f737fcd4..add11d15 100644 --- a/src/lint/engine/ArcanistLintEngine.php +++ b/src/lint/engine/ArcanistLintEngine.php @@ -274,7 +274,7 @@ abstract class ArcanistLintEngine extends Phobject { return ArcanistLintSeverity::isAtLeastAsSevere($severity, $minimum); } - final private function shouldUseCache( + private function shouldUseCache( $cache_granularity, $repository_version) { @@ -313,7 +313,7 @@ abstract class ArcanistLintEngine extends Phobject { return $this; } - final private function isRelevantMessage(ArcanistLintMessage $message) { + private function isRelevantMessage(ArcanistLintMessage $message) { // When a user runs "arc lint", we default to raising only warnings on // lines they have changed (errors are still raised anywhere in the // file). The list of $changed lines may be null, to indicate that the diff --git a/src/lint/linter/ArcanistLinter.php b/src/lint/linter/ArcanistLinter.php index afb8cbe3..85a94453 100644 --- a/src/lint/linter/ArcanistLinter.php +++ b/src/lint/linter/ArcanistLinter.php @@ -291,7 +291,7 @@ abstract class ArcanistLinter extends Phobject { * @param list * @return list */ - final private function filterPaths(array $paths) { + private function filterPaths(array $paths) { $engine = $this->getEngine(); $keep = array(); diff --git a/src/unit/engine/phutil/PhutilTestCase.php b/src/unit/engine/phutil/PhutilTestCase.php index fddb0681..efa946d9 100644 --- a/src/unit/engine/phutil/PhutilTestCase.php +++ b/src/unit/engine/phutil/PhutilTestCase.php @@ -408,7 +408,7 @@ abstract class PhutilTestCase extends Phobject { * * @task internal */ - final private function failTest($reason) { + private function failTest($reason) { $this->resultTest(ArcanistUnitTestResult::RESULT_FAIL, $reason); } @@ -421,7 +421,7 @@ abstract class PhutilTestCase extends Phobject { * * @task internal */ - final private function passTest($reason) { + private function passTest($reason) { $this->resultTest(ArcanistUnitTestResult::RESULT_PASS, $reason); } @@ -433,12 +433,12 @@ abstract class PhutilTestCase extends Phobject { * @return void * @task internal */ - final private function skipTest($reason) { + private function skipTest($reason) { $this->resultTest(ArcanistUnitTestResult::RESULT_SKIP, $reason); } - final private function resultTest($test_result, $reason) { + private function resultTest($test_result, $reason) { $coverage = $this->endCoverage(); $result = new ArcanistUnitTestResult(); @@ -553,7 +553,7 @@ abstract class PhutilTestCase extends Phobject { /** * @phutil-external-symbol function xdebug_start_code_coverage */ - final private function beginCoverage() { + private function beginCoverage() { if (!$this->enableCoverage) { return; } @@ -566,7 +566,7 @@ abstract class PhutilTestCase extends Phobject { * @phutil-external-symbol function xdebug_get_code_coverage * @phutil-external-symbol function xdebug_stop_code_coverage */ - final private function endCoverage() { + private function endCoverage() { if (!$this->enableCoverage) { return; } @@ -618,7 +618,7 @@ abstract class PhutilTestCase extends Phobject { return $coverage; } - final private function assertCoverageAvailable() { + private function assertCoverageAvailable() { if (!function_exists('xdebug_start_code_coverage')) { throw new Exception( pht("You've enabled code coverage but XDebug is not installed.")); @@ -675,7 +675,7 @@ abstract class PhutilTestCase extends Phobject { * * @return map */ - final private static function getCallerInfo() { + private static function getCallerInfo() { $callee = array(); $caller = array(); $seen = false; diff --git a/src/utils/AbstractDirectedGraph.php b/src/utils/AbstractDirectedGraph.php index 509f0f5f..24611c14 100644 --- a/src/utils/AbstractDirectedGraph.php +++ b/src/utils/AbstractDirectedGraph.php @@ -318,7 +318,7 @@ abstract class AbstractDirectedGraph extends Phobject { * which cycle. * @task cycle */ - final private function performCycleDetection($node, array $visited) { + private function performCycleDetection($node, array $visited) { $visited[$node] = true; foreach ($this->knownNodes[$node] as $edge) { if (isset($visited[$edge])) { diff --git a/src/workflow/ArcanistWorkflow.php b/src/workflow/ArcanistWorkflow.php index edad2d8d..9d6adb91 100644 --- a/src/workflow/ArcanistWorkflow.php +++ b/src/workflow/ArcanistWorkflow.php @@ -728,7 +728,7 @@ abstract class ArcanistWorkflow extends Phobject { return $this->workingDirectory; } - final private function setParentWorkflow($parent_workflow) { + private function setParentWorkflow($parent_workflow) { $this->parentWorkflow = $parent_workflow; return $this; } @@ -1377,7 +1377,7 @@ abstract class ArcanistWorkflow extends Phobject { )); } - final private function loadBundleFromConduit( + private function loadBundleFromConduit( ConduitClient $conduit, $params) {