From 3f4f8992fba8d1f142974da36a82bae900e247c0 Mon Sep 17 00:00:00 2001 From: Alan Huang Date: Wed, 13 Jun 2012 16:01:29 -0700 Subject: [PATCH] Exit with an error code if the workflow returned one. Summary: PHP thinks this thing is an integer... and also thinks it's not an integer... I'm so confused... Anyway, this seems to persuade it to use the correct overload. Test Plan: Ran arc patch with the incant provided in the bug report. It successfully returned 1, where it didn't before. I didn't test the perflab stuff; hopefully that aborts when it detects nonzero return. Reviewers: nh Reviewed By: nh CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D2743 --- scripts/arcanist.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/arcanist.php b/scripts/arcanist.php index d9715153..88344341 100755 --- a/scripts/arcanist.php +++ b/scripts/arcanist.php @@ -288,7 +288,7 @@ try { $workflow->willRunWorkflow(); $err = $workflow->run(); $config->didRunWorkflow($command, $workflow, $err); - exit($err); + exit((int)$err); } catch (ArcanistUsageException $ex) { echo phutil_console_format(