revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-22 20:51:09 +01:00
Code Issues Releases Wiki Activity

Fix some format strings

Browse source 
Summary: These `pht` calls use `%d` instead of `%s`.

Test Plan: Eyeball it.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12994
This commit is contained in:
Joshua Spence 2015-05-25 21:20:43 +10:00
parent 1f2b51c4a3
commit 410331db75
2 changed files with 9 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/workflow/ArcanistDiffWorkflow.php
View file

@ -946,17 +946,15 @@ EOTEXT
}
if (count($changes) > 250) {
$count = number_format(count($changes));
$link =
'http://www.phabricator.com/docs/phabricator/article/'.
'Differential_User_Guide_Large_Changes.html';
$message = pht(
'This diff has a very large number of changes (%d). Differential '.
'This diff has a very large number of changes (%s). Differential '.
'works best for changes which will receive detailed human review, '.
'and not as well for large automated changes or bulk checkins. '.
'See %s for information about reviewing big checkins. Continue anyway?',
$count,
$link);
new PhutilNumber(count($changes)),
'http://www.phabricator.com/docs/phabricator/article/'.
'Differential_User_Guide_Large_Changes.html');
if (!phutil_console_confirm($message)) {
throw new ArcanistUsageException(
pht('Aborted generation of gigantic diff.'));
@ -970,13 +968,11 @@ EOTEXT
$size += strlen($hunk->getCorpus());
}
if ($size > $limit) {
$file_name = $change->getCurrentPath();
$change_size = number_format($size);
$byte_warning = pht(
"Diff for '%s' with context is %d bytes in length. ".
"Diff for '%s' with context is %s bytes in length. ".
"Generally, source changes should not be this large.",
$file_name,
$change_size);
$change->getCurrentPath(),
new PhutilNumber($size));
if (!$this->getArgument('less-context')) {
$byte_warning .= ' '.pht(
"If this file is a huge text file, try using the '%s' flag.",

3
src/workflow/ArcanistDownloadWorkflow.php
View file

@ -86,8 +86,7 @@ EOTEXT
'id' => $this->id,
));
$bytes = number_format($info['byteSize']);
$desc = pht('(%d bytes)', $bytes);
$desc = pht('(%s bytes)', new PhutilNumber($info['byteSize']));
if ($info['name']) {
$desc = "'".$info['name']."' ".$desc;
}