From 4181fbde12a75e46b78805de53f12b704e7e6981 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Sat, 17 May 2014 18:36:25 -0700 Subject: [PATCH] Fix the `ArcanistJSONLintLinter::getVersion` function. Summary: Ref T4954. There was a typo in the original implementation. It wasn't noticed until now because the `getVersion` function isn't really used anywhere. Test Plan: Ran `arc linters` in a repository with `ArcanistJSONLintLinter` configured, noticed that the version number appeared in the output. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4954 Differential Revision: https://secure.phabricator.com/D9160 --- src/lint/linter/ArcanistJSONLintLinter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lint/linter/ArcanistJSONLintLinter.php b/src/lint/linter/ArcanistJSONLintLinter.php index fd49b89c..a4591cfa 100644 --- a/src/lint/linter/ArcanistJSONLintLinter.php +++ b/src/lint/linter/ArcanistJSONLintLinter.php @@ -37,7 +37,7 @@ final class ArcanistJSONLintLinter extends ArcanistExternalLinter { $matches = array(); if (preg_match('/^(?P\d+\.\d+\.\d+)$/', $stdout, $matches)) { - $version = $matches['version']; + return $matches['version']; } else { return false; }