revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Fix PHP compatibility linter after improvements to parsing of use statements

Browse source 
Summary: Fix the `PHPCompatibilityXHPASTLinterRule` after changes to the way in which #xhpast parses `use` statements. Depends on D14518.

Test Plan: Unit tests

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14519
This commit is contained in:
Joshua Spence 2015-11-20 06:50:08 +11:00
parent 3ac313ad1e
commit 426d535b13
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php
View file

@ -295,9 +295,6 @@ final class ArcanistPHPCompatibilityXHPASTLinterRule
// NOTE: This is only "use x;", in anonymous functions the node type is // NOTE: This is only "use x;", in anonymous functions the node type is
// n_LEXICAL_VARIABLE_LIST even though both tokens are T_USE. // n_LEXICAL_VARIABLE_LIST even though both tokens are T_USE.
// TODO: We parse n_USE in a slightly crazy way right now; that would be
// a better selector once it's fixed.
$uses = $root->selectDescendantsOfType('n_USE_LIST'); $uses = $root->selectDescendantsOfType('n_USE_LIST');
foreach ($uses as $use) { foreach ($uses as $use) {
$this->raiseLintAtNode( $this->raiseLintAtNode(

2
src/lint/linter/xhpast/rules/__tests__/php-compatibility/php53-features.lint-test
View file

@ -12,7 +12,7 @@ $a::m();
echo __DIR__; echo __DIR__;
~~~~~~~~~~ ~~~~~~~~~~
error:3:1 error:3:1
error:4:5 error:4:1
error:5:3 error:5:3
error:6:3 error:6:3
error:7:1 error:7:1