From 4371cd81f51161760fda843eee641b4fc1def2a2 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 16 Jun 2014 04:50:59 +1000 Subject: [PATCH] Restore PEP8 errors. Summary: As per the TODO comment, now that `.arclint` is more mature, we should be able to restore PEP8 errors. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9473 --- src/lint/linter/ArcanistPEP8Linter.php | 7 +------ src/lint/linter/__tests__/pep8/imports.lint-test | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php index bb93acb4..0b19006d 100644 --- a/src/lint/linter/ArcanistPEP8Linter.php +++ b/src/lint/linter/ArcanistPEP8Linter.php @@ -109,12 +109,7 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter { if (preg_match('/^W/', $code)) { return ArcanistLintSeverity::SEVERITY_WARNING; } else { - - // TODO: Once severities/.arclint are more usable, restore this to - // "ERROR". - // return ArcanistLintSeverity::SEVERITY_ERROR; - - return ArcanistLintSeverity::SEVERITY_WARNING; + return ArcanistLintSeverity::SEVERITY_ERROR; } } diff --git a/src/lint/linter/__tests__/pep8/imports.lint-test b/src/lint/linter/__tests__/pep8/imports.lint-test index 54ef8efd..cd9b2287 100644 --- a/src/lint/linter/__tests__/pep8/imports.lint-test +++ b/src/lint/linter/__tests__/pep8/imports.lint-test @@ -1,3 +1,3 @@ import os, sys ~~~~~~~~~~ -warning:1:10 +error:1:10