revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-01 19:22:41 +01:00
Code Issues Releases Wiki Activity

Restore PEP8 errors.

Browse source 
Summary: As per the TODO comment, now that `.arclint` is more mature, we should be able to restore PEP8 errors.

Test Plan: N/A

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9473
This commit is contained in:
Joshua Spence 2014-06-16 04:50:59 +10:00
parent 45c66a1a7b
commit 4371cd81f5
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/lint/linter/ArcanistPEP8Linter.php
View file

@ -109,12 +109,7 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
if (preg_match('/^W/', $code)) { if (preg_match('/^W/', $code)) {
return ArcanistLintSeverity::SEVERITY_WARNING; return ArcanistLintSeverity::SEVERITY_WARNING;
} else { } else {
return ArcanistLintSeverity::SEVERITY_ERROR;
// TODO: Once severities/.arclint are more usable, restore this to
// "ERROR".
// return ArcanistLintSeverity::SEVERITY_ERROR;
return ArcanistLintSeverity::SEVERITY_WARNING;
} }
} }

2
src/lint/linter/__tests__/pep8/imports.lint-test
View file

@ -1,3 +1,3 @@
import os, sys import os, sys
~~~~~~~~~~ ~~~~~~~~~~
warning:1:10 error:1:10