From 439413ae29b5468ef013ae2e136f8d2ecf266425 Mon Sep 17 00:00:00 2001 From: jjoos Date: Tue, 6 Jan 2015 06:59:36 -0800 Subject: [PATCH] Remove the noconfig flag Summary: D11196 introduced a regression that made it impossible for coffeelint to read any configuration. I'm reverting the change in that diff. Created a pull request changing the documentation of coffeelint to make sure I'm interpreting this flag correctly: https://github.com/clutchski/coffeelint/pull/364 Test Plan: - patch - npm install -g coffeelint - create a `test.coffee` file with: ``` # 1234567890 ``` - `arc lint test.coffee` ``` OKAY No lint warnings. ``` - create a `coffeelint.json` with ``` { "max_line_length": { "value": 10 } } ``` - `arc lint test.coffee`, expected output: ``` >>> Lint for test.coffee: Error (COFFEE) Line exceeds maximum allowed length. >>> 1 # 1234567890 ``` - create a `.arclint` with ``` { "linters": { "coffeelint": { "type": "coffeelint", "coffeelint.config": "coffee_lint_config_with_different_name.json" } } } ``` - rename `coffeelint.json` to `coffee_lint_config_with_different_name.json` - `arc lint test.coffee`, expected output: ``` >>> Lint for test.coffee: Error (COFFEE) Line exceeds maximum allowed length. >>> 1 # 1234567890 ``` Reviewers: Korvin, joshuaspence, epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11250 --- src/lint/linter/ArcanistCoffeeLintLinter.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lint/linter/ArcanistCoffeeLintLinter.php b/src/lint/linter/ArcanistCoffeeLintLinter.php index 142154e5..8d911b87 100644 --- a/src/lint/linter/ArcanistCoffeeLintLinter.php +++ b/src/lint/linter/ArcanistCoffeeLintLinter.php @@ -63,7 +63,6 @@ final class ArcanistCoffeeLintLinter extends ArcanistExternalLinter { $options = array( '--reporter=checkstyle', '--color=never', - '--noconfig', ); if ($this->config) {