revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Run unit on background also in waiting for confirmation with arc diff --excuse

Browse source 
Test Plan: Made lint error, slept in test, verified that tests are finished when I confirm `arc diff --excuse`.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3803
This commit is contained in:
vrana 2012-10-23 15:21:01 -07:00
parent 0b02170723
commit 448e820eb6
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/workflow/ArcanistDiffWorkflow.php
View file

@ -1372,11 +1372,10 @@ EOTEXT
private function getErrorExcuse($type, $prompt, $history) { private function getErrorExcuse($type, $prompt, $history) {
if ($this->getArgument('excuse')) { if ($this->getArgument('excuse')) {
$prompt .= " Ignore them?"; $this->console->sendMessage(array(
if (!$this->console->confirm($prompt)) { 'type' => $type,
throw new ArcanistUserAbortException(); 'confirm' => $prompt." Ignore them?",
} ));
$this->excuses[$type] = $this->getArgument('excuse');
return; return;
} }
@ -1393,7 +1392,12 @@ EOTEXT
public function handleServerMessage(PhutilConsoleMessage $message) { public function handleServerMessage(PhutilConsoleMessage $message) {
$data = $message->getData(); $data = $message->getData();
$response = phutil_console_prompt($data['prompt'], idx($data, 'history')); $response = '';
if (isset($data['prompt'])) {
$response = phutil_console_prompt($data['prompt'], idx($data, 'history'));
} else if (phutil_console_confirm($data['confirm'])) {
$response = $this->getArgument('excuse');
}
if ($response == '') { if ($response == '') {
throw new ArcanistUserAbortException(); throw new ArcanistUserAbortException();
} }