revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Delete obsolete comment

Browse source 
Summary:
HPHP now autoloads in `is_subclass_of()`.
I've left the `class_exists()` check as the code is more explicit.

Test Plan:
  // under HPHP
  function __autoload($c) {
    echo "$c\n";
  }
  is_subclass_of('C', 'stdClass');

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3435
This commit is contained in:
vrana 2012-09-04 21:21:30 -07:00
parent a802a90123
commit 466910c700
2 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/workflow/ArcanistLintWorkflow.php
View file

@ -163,7 +163,6 @@ EOTEXT
$paths = $this->selectPathsForWorkflow($paths, $rev); $paths = $this->selectPathsForWorkflow($paths, $rev);
// is_subclass_of() doesn't autoload under HPHP.
if (!class_exists($engine) || if (!class_exists($engine) ||
!is_subclass_of($engine, 'ArcanistLintEngine')) { !is_subclass_of($engine, 'ArcanistLintEngine')) {
throw new ArcanistUsageException( throw new ArcanistUsageException(

1
src/workflow/ArcanistUnitWorkflow.php
View file

@ -116,7 +116,6 @@ EOTEXT
$paths = $this->selectPathsForWorkflow($paths, $rev); $paths = $this->selectPathsForWorkflow($paths, $rev);
// is_subclass_of() doesn't autoload under HPHP.
if (!class_exists($engine_class) || if (!class_exists($engine_class) ||
!is_subclass_of($engine_class, 'ArcanistBaseUnitTestEngine')) { !is_subclass_of($engine_class, 'ArcanistBaseUnitTestEngine')) {
throw new ArcanistUsageException( throw new ArcanistUsageException(