From 475a576fdc8ae5fc888c4a10d93827c9ef52ca14 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Fri, 19 Oct 2012 11:02:46 -0700
Subject: [PATCH] Require defining getWorkflowName()

Test Plan:
  $ arc help

Reviewers: epriestley, edward

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3742
---
 src/configuration/ArcanistConfiguration.php | 7 -------
 src/workflow/ArcanistBaseWorkflow.php       | 3 +--
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/configuration/ArcanistConfiguration.php b/src/configuration/ArcanistConfiguration.php
index ea781630..560b6432 100644
--- a/src/configuration/ArcanistConfiguration.php
+++ b/src/configuration/ArcanistConfiguration.php
@@ -58,13 +58,6 @@ class ArcanistConfiguration {
     foreach ($symbols as $symbol) {
       $class = $symbol['name'];
       $workflow = newv($class, array());
-
-      // TODO: Delete after installations will update (2012-10-31).
-      if (!method_exists($workflow, 'getWorkflowName')) {
-        // This workflow was hopefully already built by our parent.
-        continue;
-      }
-
       $name = $workflow->getWorkflowName();
 
       if (isset($workflows[$name])) {
diff --git a/src/workflow/ArcanistBaseWorkflow.php b/src/workflow/ArcanistBaseWorkflow.php
index 7e9e774d..40b851f1 100644
--- a/src/workflow/ArcanistBaseWorkflow.php
+++ b/src/workflow/ArcanistBaseWorkflow.php
@@ -89,8 +89,7 @@ abstract class ArcanistBaseWorkflow {
    *
    * @return string   The command a user types to invoke this workflow.
    */
-  // TODO: Uncomment after installations will update (2012-10-31).
-  // abstract public function getWorkflowName();
+  abstract public function getWorkflowName();
 
   /**
    * Return console formatted string with all command synopses.