revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Don't check working copy status for "arc commit --show"

Browse source 
Summary:
We do unnecessary working copy checks under "--show", even though the working copy isn't relevant.

Also, 'sourcePath' may not be set (e.g., "arc commit --show --revision X" where X is some "--only" revision).

Test Plan: Ran "arc commit --show --revision 1" against some test data, got clean output.

Reviewers: vrana, btrahan, jungejason

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2353
This commit is contained in:
epriestley 2012-05-01 10:35:14 -07:00
parent c0c3c8a113
commit 47ed2aca95
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/workflow/commit/ArcanistCommitWorkflow.php
View file

@ -122,7 +122,11 @@ EOTEXT
$this->revisionID = $revision['id']; $this->revisionID = $revision['id'];
$revision_id = $revision['id']; $revision_id = $revision['id'];
$this->runSanityChecks($revision); $is_show = $this->getArgument('show');
if (!$is_show) {
$this->runSanityChecks($revision);
}
$message = $this->getConduit()->callMethodSynchronous( $message = $this->getConduit()->callMethodSynchronous(
'differential.getcommitmessage', 'differential.getcommitmessage',
@ -142,8 +146,8 @@ EOTEXT
$message = $event->getValue('message'); $message = $event->getValue('message');
if ($this->getArgument('show')) { if ($is_show) {
echo $message; echo $message."\n";
return 0; return 0;
} }
@ -328,7 +332,7 @@ EOTEXT
"Commit this revision anyway?"; "Commit this revision anyway?";
} }
$revision_source = $revision['sourcePath']; $revision_source = idx($revision, 'sourcePath');
$current_source = $repository_api->getPath(); $current_source = $repository_api->getPath();
if ($revision_source != $current_source) { if ($revision_source != $current_source) {
$confirm[] = $confirm[] =