From 4864435a50eed859bddcfda8d99a38253e71b9d6 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Fri, 15 May 2015 07:09:30 +1000
Subject: [PATCH] Minor linter fixes

Summary: Minor linter fixes.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12836
---
 src/workflow/ArcanistBackoutWorkflow.php  | 3 ++-
 src/workflow/ArcanistBookmarkWorkflow.php | 4 ----
 src/workflow/ArcanistBranchWorkflow.php   | 4 ----
 src/workflow/ArcanistLiberateWorkflow.php | 6 ++++--
 4 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/src/workflow/ArcanistBackoutWorkflow.php b/src/workflow/ArcanistBackoutWorkflow.php
index bd554e18..cdd26119 100644
--- a/src/workflow/ArcanistBackoutWorkflow.php
+++ b/src/workflow/ArcanistBackoutWorkflow.php
@@ -183,7 +183,8 @@ EOTEXT
     // Create commit message and execute the commit
     $message = $this->buildCommitMessage($commit_hash);
     $repository_api->doCommit($message);
-    $console->writeOut(pht('Double-check the commit and push when ready.')."\n");
+    $console->writeOut("%s\n",
+      pht('Double-check the commit and push when ready.'));
   }
 
 }
diff --git a/src/workflow/ArcanistBookmarkWorkflow.php b/src/workflow/ArcanistBookmarkWorkflow.php
index 131c21b3..3fadb343 100644
--- a/src/workflow/ArcanistBookmarkWorkflow.php
+++ b/src/workflow/ArcanistBookmarkWorkflow.php
@@ -29,8 +29,4 @@ EOTEXT
     return array('hg');
   }
 
-  public function run() {
-    return parent::run();
-  }
-
 }
diff --git a/src/workflow/ArcanistBranchWorkflow.php b/src/workflow/ArcanistBranchWorkflow.php
index 7c980ef4..527ac15d 100644
--- a/src/workflow/ArcanistBranchWorkflow.php
+++ b/src/workflow/ArcanistBranchWorkflow.php
@@ -29,8 +29,4 @@ EOTEXT
     return array('git');
   }
 
-  public function run() {
-    return parent::run();
-  }
-
 }
diff --git a/src/workflow/ArcanistLiberateWorkflow.php b/src/workflow/ArcanistLiberateWorkflow.php
index c7fe1bd9..efca1bf5 100644
--- a/src/workflow/ArcanistLiberateWorkflow.php
+++ b/src/workflow/ArcanistLiberateWorkflow.php
@@ -223,8 +223,10 @@ EOTEXT
       if (preg_match('/^[a-z-]+$/', $name)) {
         break;
       } else {
-        echo pht(
-          'Library name should contain only lowercase letters and hyphens.')."\n";
+        echo phutil_console_format(
+          "%s\n",
+          pht(
+          'Library name should contain only lowercase letters and hyphens.'));
       }
     } while (true);