mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 00:42:40 +01:00
When a file doesn't begin "<?php", raise one warning, not one for each line
Summary: Linter flipped out on D1817; reign it in. Test Plan: Ran "arc lint" on D1817, got one message. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1818
This commit is contained in:
parent
54c3ad316e
commit
49b83927b8
2 changed files with 2 additions and 3 deletions
|
@ -686,6 +686,7 @@ final class ArcanistXHPASTLinter extends ArcanistLinter {
|
|||
'PHP files should start with "<?php", which may be preceded by '.
|
||||
'a "#!" line for scripts.');
|
||||
}
|
||||
break;
|
||||
}
|
||||
}
|
||||
foreach ($tokens as $token) {
|
||||
|
|
|
@ -4,11 +4,9 @@ garbage garbage
|
|||
?>
|
||||
~~~~~~~~~~
|
||||
error:1:1
|
||||
error:2:1
|
||||
error:4:1
|
||||
~~~~~~~~~~
|
||||
garbage garbage
|
||||
<?php
|
||||
|
||||
<?
|
||||
|
||||
?>
|
||||
|
|
Loading…
Reference in a new issue