revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity

Fix two common points of confusion:

Browse source 
- show "push upstream" instructions after arc amend
	- parse 'diffcamp revision'

Summary:

Test Plan:

Reviewers:

CC:
This commit is contained in:
epriestley 2011-02-16 18:47:17 -08:00
parent ba6091f945
commit 4b1c4238bc
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/differential/commitmessage/ArcanistDifferentialCommitMessage.php
View file

@ -30,8 +30,9 @@ class ArcanistDifferentialCommitMessage {
$obj = new ArcanistDifferentialCommitMessage(); $obj = new ArcanistDifferentialCommitMessage();
$obj->rawCorpus = $corpus; $obj->rawCorpus = $corpus;
// TODO: Remove "Diffcamp" backward compatibility.
$match = null; $match = null;
if (preg_match('/^Differential Revision:\s*D?(\d+)/m', $corpus, $match)) { if (preg_match('/^(?:Differential|DiffCamp) Revision:\s*D?(\d+)/im', $corpus, $match)) {
$obj->revisionID = (int)$match[1]; $obj->revisionID = (int)$match[1];
} }

4
src/workflow/amend/ArcanistAmendWorkflow.php
View file

@ -126,6 +126,10 @@ EOTEXT
} }
} }
echo phutil_console_wrap(
"You may now push this commit upstream, as appropriate (e.g. with ".
"'git push', or 'git svn dcommit', or by printing and faxing it).\n");
return 0; return 0;
} }