revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Don't pass data to jshint via STDIN

Browse source 
Summary: Fixes T7464. JSHint is unable to exclude files from linting (via the `jshintignore` file) if the data is piped through `STDIN`. An alternative would be to pass `$options[] = '--filename='.$this->getActivePath()`, but `$this->getActivePath()` is not set when the command arguments are constructed.

Test Plan: Created a file and linted it with `ArcanistJSHintLinter`. Was able to exclude the file from linting with a `jshintignore` file.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7464

Differential Revision: https://secure.phabricator.com/D12298
This commit is contained in:
Joshua Spence 2015-04-07 07:26:09 +10:00
parent 637832d06f
commit 4b2d8e3f69
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/lint/linter/ArcanistJSHintLinter.php
View file

@ -73,14 +73,6 @@ final class ArcanistJSHintLinter extends ArcanistExternalLinter {
return pht('Install JSHint using `npm install -g jshint`.'); return pht('Install JSHint using `npm install -g jshint`.');
} }
public function supportsReadDataFromStdin() {
return true;
}
public function getReadDataFromStdinFilename() {
return '-';
}
protected function getMandatoryFlags() { protected function getMandatoryFlags() {
$options = array(); $options = array();