1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-11 07:11:03 +01:00

Warn before parse errors in arc diff --verbatim

Summary: With `--verbatim` flag, notes created from parse errors are never displayed to user resulting in blank fields.

Test Plan:
- `arc diff --verbatim` with invalid Cc
- `arc diff --verbatim` with all fields correct

Reviewers: epriestley, jungejason

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2395
This commit is contained in:
vrana 2012-05-04 12:22:47 -07:00
parent 4645204c11
commit 4d1e5b1b74

View file

@ -1598,6 +1598,10 @@ EOTEXT
$message->pullDataFromConduit($conduit, $partial = true);
$fields += $message->getFields();
} catch (ArcanistDifferentialCommitMessageParserException $ex) {
if ($this->getArgument('verbatim')) {
throw $ex;
}
$fields += $message->getFields();
$frev = substr($hash, 0, 8);