1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00

Use PhutilClassMapQuery

Summary: Use `PhutilClassMapQuery` where appropriate.

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13428
This commit is contained in:
Joshua Spence 2015-07-07 19:22:12 +10:00
parent bbccf1dd40
commit 4d6d3feb7f

View file

@ -6,29 +6,10 @@ abstract class ArcanistXHPASTLinterRule extends Phobject {
private $lintID = null;
final public static function loadAllRules() {
$rules = array();
$symbols = id(new PhutilSymbolLoader())
return id(new PhutilClassMapQuery())
->setAncestorClass(__CLASS__)
->loadObjects();
foreach ($symbols as $class => $rule) {
$id = $rule->getLintID();
if (isset($rules[$id])) {
throw new Exception(
pht(
'Two linter rules (`%s`, `%s`) share the same lint ID (%d). '.
'Each linter rule must have a unique ID.',
$class,
get_class($rules[$id]),
$id));
}
$rules[$id] = $rule;
}
return $rules;
->setUniqueMethod('getLintID')
->execute();
}
final public function getLintID() {