revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-23 05:50:54 +01:00
Code Issues Releases Wiki Activity

Call $linter->setEngine in linter tests

Browse source 
Summary: We aren't calling `$linter->setEngine($engine)`, even though we do have an `$engine`. This causes unit tests for any linters which require an engine to fail.

Test Plan: Ran the unit tests for a [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php | third-party linter]].

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D20515
This commit is contained in:
Joshua Spence 2019-05-15 09:00:29 +10:00
parent 9ccbbee336
commit 4f583dded3
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/lint/linter/__tests__/ArcanistLinterTestCase.php
View file

@ -114,6 +114,7 @@ abstract class ArcanistLinterTestCase extends PhutilTestCase {
$path_name = idx($config, 'path', $path); $path_name = idx($config, 'path', $path);
$engine->setPaths(array($path_name)); $engine->setPaths(array($path_name));
$linter->setEngine($engine);
$linter->addPath($path_name); $linter->addPath($path_name);
$linter->addData($path_name, $data); $linter->addData($path_name, $data);