mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-22 06:42:41 +01:00
Only lint files in the working copy with arc lint --everything
.
Summary: Fixes T5442. `arc lint --everything` currently uses a `FileFinder` to discover paths for linting. A consequence of this is that files that are ignored or otherwise excluded from version control are linted. Test Plan: Ran `arc lint --everything` in rPHU and noticed that I wasn't prompted to add a trailing newline to `src/.phutil_module_cache`. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Maniphest Tasks: T5442 Differential Revision: https://secure.phabricator.com/D9674
This commit is contained in:
parent
b2aeca1963
commit
4fd6c99a93
1 changed files with 1 additions and 15 deletions
|
@ -218,21 +218,7 @@ EOTEXT
|
||||||
}
|
}
|
||||||
|
|
||||||
if ($everything) {
|
if ($everything) {
|
||||||
// Recurse through project from root
|
$paths = iterator_to_array($this->getRepositoryApi()->getAllFiles());
|
||||||
switch ($this->getRepositoryApi()->getSourceControlSystemName()) {
|
|
||||||
case 'git':
|
|
||||||
$filter = '*/.git';
|
|
||||||
break;
|
|
||||||
case 'svn':
|
|
||||||
$filter = '*/.svn';
|
|
||||||
break;
|
|
||||||
case 'hg':
|
|
||||||
$filter = '*/.hg';
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
$paths = id(new FileFinder($working_copy->getProjectRoot()))
|
|
||||||
->excludePath($filter)
|
|
||||||
->find();
|
|
||||||
$this->shouldLintAll = true;
|
$this->shouldLintAll = true;
|
||||||
} else {
|
} else {
|
||||||
$paths = $this->selectPathsForWorkflow($paths, $rev);
|
$paths = $this->selectPathsForWorkflow($paths, $rev);
|
||||||
|
|
Loading…
Reference in a new issue