revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

escape files properly in arc commit

Browse source 
Summary: turns out retina has files like image.png and image@2x.png. The latter breaks since '@' is a special command telling svn to "look for image at revision 2x.png" -- nonsensical garbage. If we add it to the end every time this error goes way.

Test Plan: touch 2@2.png; svn add '2@2@'; arc diff; <fill out form, accept commit>; arc commit -- observe commit working

Reviewers: epriestley

Reviewed By: epriestley

CC: mbishopim3, aran, Korvin

Maniphest Tasks: T1999

Differential Revision: https://secure.phabricator.com/D3845
This commit is contained in:
Bob Trahan 2012-10-30 18:26:58 -07:00
parent 44842aeb25
commit 522c35c1ed
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/workflow/ArcanistCommitWorkflow.php
View file

@ -261,7 +261,10 @@ EOTEXT
$this->promptFileWarning($prefix, $prompt, $do_not_exist);
}
$files = array_keys($commit_paths);
$files = array();
foreach ($commit_paths as $file => $ignored) {
$files[] = $file.'@'; // make SVN accept commits like foo@2x.png
}
if (empty($files)) {
throw new ArcanistUsageException(