mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-26 00:32:41 +01:00
Strip comments during arc diff --verbatim
workflow before submitting to Phabricator
Summary: Fixes T4649. The issue in that task is caused because we're submitting a block of text including comments. We've probably been doing this for a long time, but maybe were more liberal in parsing before. Instead, strip them. Test Plan: Ran `arc diff --verbatim` and got "Dxxx" prefilled correctly. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4649 Differential Revision: https://secure.phabricator.com/D8658
This commit is contained in:
parent
a36969e58b
commit
5280f3708e
1 changed files with 2 additions and 0 deletions
|
@ -745,6 +745,8 @@ EOTEXT
|
|||
if ($this->commitMessageFromRevision == $remote_corpus) {
|
||||
$new_message = $message;
|
||||
} else {
|
||||
$remote_corpus = ArcanistCommentRemover::removeComments(
|
||||
$remote_corpus);
|
||||
$new_message = ArcanistDifferentialCommitMessage::newFromRawCorpus(
|
||||
$remote_corpus);
|
||||
$new_message->pullDataFromConduit($conduit);
|
||||
|
|
Loading…
Reference in a new issue