revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Rename "arc diff --preview" to "arc diff --only"

Browse source 
Summary:
Experimental branch. Depends on D18739. Ref T2543.

To prepare for `--draft`, consolidate `--preview` and `--only`.

The old `--preview` is now `arc diff --only`.

The old `--only` is now `arc diff --only --nounit --nolint`.

I think this is more clear than other ways we could do it, since the difference between "draft" and "preview" seems less clear than the difference between "draft" and "only".

Test Plan: Ran `arc diff --only` and `arc diff --only --nounit --nolint`.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18740
This commit is contained in:
epriestley 2017-10-27 09:22:26 -07:00
parent 4c4f2e6674
commit 52992b9550
1 changed files with 12 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/workflow/ArcanistDiffWorkflow.php
View file

@ -113,7 +113,7 @@ EOTEXT
'param' => 'commit',
'help' => pht('Read revision information from a specific commit.'),
'conflicts' => array(
'preview' => null,
'only' => null,
'update' => null,
),
),
@ -175,10 +175,10 @@ EOTEXT
'%s can not be used with %s.',
'--create',
'--edit'),
'preview' => pht(
'only' => pht(
'%s can not be used with %s.',
'--create',
'--preview'),
'--only'),
'update' => pht(
'%s can not be used with %s.',
'--create',
@ -201,14 +201,13 @@ EOTEXT
'never-apply-patches' => pht('%s suppresses lint.', '--nolint'),
),
),
'preview' => array(
'only' => array(
'help' => pht(
'Instead of creating or updating a revision, only create a diff, '.
'which you may later attach to a revision. This still runs lint '.
'unit tests.'),
'which you may later attach to a revision.'),
'conflicts' => array(
'edit' => pht('%s does affect revisions.', '--preview'),
'message' => pht('%s does not update any revision.', '--preview'),
'edit' => pht('%s does affect revisions.', '--only'),
'message' => pht('%s does not update any revision.', '--only'),
),
),
'encoding' => array(
@ -321,7 +320,7 @@ EOTEXT
'conflicts' => array(
'use-commit-message' => true,
'update' => true,
'preview' => true,
'only' => true,
'raw' => true,
'raw-command' => true,
'message-file' => true,
@ -331,7 +330,7 @@ EOTEXT
'param' => 'usernames',
'help' => pht('When creating a revision, add reviewers.'),
'conflicts' => array(
'preview' => true,
'only' => true,
'update' => true,
),
),
@ -339,7 +338,7 @@ EOTEXT
'param' => 'usernames',
'help' => pht('When creating a revision, add CCs.'),
'conflicts' => array(
'preview' => true,
'only' => true,
'update' => true,
),
),
@ -737,7 +736,7 @@ EOTEXT
return true;
}
return $this->getArgument('preview');
return $this->getArgument('only');
}
private function generateAffectedPaths() {
@ -1397,7 +1396,7 @@ EOTEXT
* @task message
*/
private function buildCommitMessage() {
if ($this->getArgument('preview')) {
if ($this->getArgument('only')) {
return null;
}