revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Fix PhutilLibraryMapBuilder to call the right function in log()

Browse source 
Summary:
`arc liberate` has been broken for a while because the `log` function attempts to call `fwrite` (whose third argument is an integer length) instead of `fprintf`. I think maybe PHP 5 was more lenient about this? Anyway, this bug makes other development somewhat tricky.

The arcanist source in general seems to be split between `fwrite(STDERR, $message."\n")` and `fprintf(STDERR, "%\n", $message)`; I decided to go with the latter.

This is sort of a test balloon on submitting diffs to Phorge. Please feel free to let me know if there's anything you'd like done differently!

Test Plan: Ran `arc liberate` to regenerate source maps and didn't get any errors

Reviewers: O1 Blessed Committers, eax

Reviewed By: O1 Blessed Committers, eax

Subscribers: chris, speck, tobiaswiese

Differential Revision: https://we.phorge.it/D25017
This commit is contained in:
James Brown 2021-08-02 15:48:15 -07:00
parent 7498c10215
commit 5407e5e5c6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/moduleutils/PhutilLibraryMapBuilder.php
View file

@ -122,7 +122,7 @@ final class PhutilLibraryMapBuilder extends Phobject {
*/ */
private function log($message) { private function log($message) {
if (!$this->quiet) { if (!$this->quiet) {
@fwrite(STDERR, "%s\n", $message); @fprintf(STDERR, "%s\n", $message);
} }
return $this; return $this;
} }