revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-02-16 16:58:38 +01:00
Code Issues Releases Wiki Activity

Return $this from setter methods

Browse source 
Summary: Return `$this` from a bunch of setter methods for consistency. See also D13422.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13423
This commit is contained in:
Joshua Spence 2015-06-25 22:30:33 +10:00
parent 04d788c79e
commit 5466451b76
4 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/configuration/ArcanistConfigurationManager.php
View file

@ -13,6 +13,7 @@ final class ArcanistConfigurationManager extends Phobject {
public function setWorkingCopyIdentity( public function setWorkingCopyIdentity(
ArcanistWorkingCopyIdentity $working_copy) { ArcanistWorkingCopyIdentity $working_copy) {
$this->workingCopy = $working_copy; $this->workingCopy = $working_copy;
return $this;
} }
/* -( Get config )--------------------------------------------------------- */ /* -( Get config )--------------------------------------------------------- */
@ -243,6 +244,7 @@ final class ArcanistConfigurationManager extends Phobject {
$this->customArcrcFilename = $custom_arcrc; $this->customArcrcFilename = $custom_arcrc;
$this->userConfigCache = null; $this->userConfigCache = null;
return $this;
} }
public function getUserConfigurationFileLocation() { public function getUserConfigurationFileLocation() {

1
src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
View file

@ -69,6 +69,7 @@ abstract class ArcanistXHPASTLinterRule extends Phobject {
final public function setLinter(ArcanistXHPASTLinter $linter) { final public function setLinter(ArcanistXHPASTLinter $linter) {
$this->linter = $linter; $this->linter = $linter;
return $this;
} }
/** /**