revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Return $this from setter methods

Browse source 
Summary: Return `$this` from a bunch of setter methods for consistency. See also D13422.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13423
This commit is contained in:
Joshua Spence 2015-06-25 22:30:33 +10:00
parent 04d788c79e
commit 5466451b76
4 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/configuration/ArcanistConfigurationManager.php
View file

@ -13,6 +13,7 @@ final class ArcanistConfigurationManager extends Phobject {
public function setWorkingCopyIdentity( public function setWorkingCopyIdentity(
ArcanistWorkingCopyIdentity $working_copy) { ArcanistWorkingCopyIdentity $working_copy) {
$this->workingCopy = $working_copy; $this->workingCopy = $working_copy;
return $this;
} }
/* -( Get config )--------------------------------------------------------- */ /* -( Get config )--------------------------------------------------------- */
@ -243,6 +244,7 @@ final class ArcanistConfigurationManager extends Phobject {
$this->customArcrcFilename = $custom_arcrc; $this->customArcrcFilename = $custom_arcrc;
$this->userConfigCache = null; $this->userConfigCache = null;
return $this;
} }
public function getUserConfigurationFileLocation() { public function getUserConfigurationFileLocation() {

1
src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
View file

@ -69,6 +69,7 @@ abstract class ArcanistXHPASTLinterRule extends Phobject {
final public function setLinter(ArcanistXHPASTLinter $linter) { final public function setLinter(ArcanistXHPASTLinter $linter) {
$this->linter = $linter; $this->linter = $linter;
return $this;
} }
/** /**

2
src/unit/engine/NoseTestEngine.php
View file

@ -64,7 +64,7 @@ final class NoseTestEngine extends ArcanistUnitTestEngine {
foreach ($futures as $test_path => $future) { foreach ($futures as $test_path => $future) {
try { try {
list($stdout, $stderr) = $future->resolvex(); list($stdout, $stderr) = $future->resolvex();
} catch(CommandException $exc) { } catch (CommandException $exc) {
if ($exc->getError() > 1) { if ($exc->getError() > 1) {
// 'nose' returns 1 when tests are failing/broken. // 'nose' returns 1 when tests are failing/broken.
throw $exc; throw $exc;

4
src/unit/engine/XUnitTestEngine.php
View file

@ -250,7 +250,7 @@ class XUnitTestEngine extends ArcanistUnitTestEngine {
try { try {
$regenerate_future->resolvex(); $regenerate_future->resolvex();
$result->setResult(ArcanistUnitTestResult::RESULT_PASS); $result->setResult(ArcanistUnitTestResult::RESULT_PASS);
} catch(CommandException $exc) { } catch (CommandException $exc) {
if ($exc->getError() > 1) { if ($exc->getError() > 1) {
throw $exc; throw $exc;
} }
@ -296,7 +296,7 @@ class XUnitTestEngine extends ArcanistUnitTestEngine {
try { try {
$future->resolvex(); $future->resolvex();
$result->setResult(ArcanistUnitTestResult::RESULT_PASS); $result->setResult(ArcanistUnitTestResult::RESULT_PASS);
} catch(CommandException $exc) { } catch (CommandException $exc) {
if ($exc->getError() > 1) { if ($exc->getError() > 1) {
throw $exc; throw $exc;
} }