mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 08:52:39 +01:00
Allow to push revisions to review by himself to Differential (bug T1879, change 2/2, Arcanist part)
Summary: The 'review its own revision' check is now handled by Differential (bug T1879) Previous behavior: arc threw an "You can not be a reviewer for your own revision." exception if an users adds itself as reviewer, even when this configuration is allowed on the Differential remote install's configuration. New behavior: Arc doesn't check that anymore. It still will be checked by the server. Test Plan: Tested locally pushing revisions with "arc diff" to a Phabricator server with differential.allow-self-accept at true or false with myself or not as reviewer. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1879 Differential Revision: https://secure.phabricator.com/D3674
This commit is contained in:
parent
a63db7cd6e
commit
5725585f2d
1 changed files with 0 additions and 3 deletions
|
@ -1716,9 +1716,6 @@ EOTEXT
|
|||
if (!phutil_console_confirm($confirm)) {
|
||||
throw new ArcanistUsageException('Specify reviewers and retry.');
|
||||
}
|
||||
} else if (in_array($this->getUserPHID(), $reviewers)) {
|
||||
throw new ArcanistUsageException(
|
||||
"You can not be a reviewer for your own revision.");
|
||||
} else {
|
||||
$users = $this->getConduit()->callMethodSynchronous(
|
||||
'user.query',
|
||||
|
|
Loading…
Reference in a new issue