revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Handle arc diff --background 1 --

Browse source 
Summary: We currently insert background parameters to end which causes ignoring them if there is '--'.

Test Plan:
  $ arc diff --background 1 -- HEAD^

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3497
This commit is contained in:
vrana 2012-09-14 18:46:33 -07:00
parent 3bbf9ccc3d
commit 589bccb716
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/workflow/ArcanistDiffWorkflow.php
View file

@ -373,10 +373,13 @@ EOTEXT
if ($this->getArgument('background')) {
$argv = $_SERVER['argv'];
// Insert after `arc diff`.
array_splice($argv, 2, 0, array('--recon', '--no-diff'));
if (!PhutilConsoleFormatter::getDisableANSI()) {
$argv[] = '--ansi';
// Insert after `arc`.
array_splice($argv, 1, 0, array('--ansi'));
}
$lint_unit = new ExecFuture('%Ls --recon --no-diff', $argv);
$lint_unit = new ExecFuture('%Ls', $argv);
$lint_unit->write('', true);
$lint_unit->start();
}