From 592172c77559ba0b97f7e6d39c4ec47080f9e930 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 14 May 2013 13:35:42 -0700
Subject: [PATCH] Remove "--allow-empty-message"

Summary: @alex has git 1.7.0.4 which doesn't have this flag. We don't actually need it: we always provide a commit message when calling this method. Remove the flag for compatibility, leaving a note in case we bump into this in the future.

Test Plan: N/A

Reviewers: btrahan, vrana, alex

Reviewed By: alex

CC: aran

Differential Revision: https://secure.phabricator.com/D5926
---
 src/repository/api/ArcanistGitAPI.php | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/repository/api/ArcanistGitAPI.php b/src/repository/api/ArcanistGitAPI.php
index 3ddb6470..17475884 100644
--- a/src/repository/api/ArcanistGitAPI.php
+++ b/src/repository/api/ArcanistGitAPI.php
@@ -531,8 +531,12 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
   public function doCommit($message) {
     $tmp_file = new TempFile();
     Filesystem::writeFile($tmp_file, $message);
+
+    // NOTE: "--allow-empty-message" was introduced some time after 1.7.0.4,
+    // so we do not provide it and thus require a message.
+
     $this->execxLocal(
-      'commit --allow-empty-message -F %s',
+      'commit -F %s',
       $tmp_file);
 
     $this->reloadWorkingCopy();