revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Disable phutil filename check. To be implemented as a more pervasive check.

Browse source 
Differential Revision: 201587
Reviewed By: epriestley
This commit is contained in:
adonohue 2011-01-14 13:26:01 -08:00
parent 68dee48bf4
commit 59f48f7901
2 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
scripts/phutil_analyzer.php
View file

@ -233,21 +233,6 @@ foreach (Futures($futures) as $file => $future) {
"file."); "file.");
break; break;
} }
} else if (count($classes) == 1) {
foreach ($classes as $class) {
$class_name = $class->getChildByIndex(1);
$class_string = $class_name->getConcreteString();
if ($file != $class_string.'.php') {
$rename = $class_string.'.php';
$requirements->addLint(
$class_name,
$class_string,
ArcanistPhutilModuleLinter::LINT_ANALYZER_CLASS_FILENAME,
"The name of this file differs from the name of the class it ".
"declares. Rename the file to '{$rename}'.");
}
break;
}
} }
$uses_of_new = $root->selectDescendantsOfType('n_NEW'); $uses_of_new = $root->selectDescendantsOfType('n_NEW');

3
src/lint/linter/phutilmodule/ArcanistPhutilModuleLinter.php
View file

@ -32,7 +32,6 @@ class ArcanistPhutilModuleLinter extends ArcanistLinter {
const LINT_ANALYZER_DYNAMIC = 101; const LINT_ANALYZER_DYNAMIC = 101;
const LINT_ANALYZER_NO_INIT = 102; const LINT_ANALYZER_NO_INIT = 102;
const LINT_ANALYZER_MULTIPLE_CLASSES = 103; const LINT_ANALYZER_MULTIPLE_CLASSES = 103;
const LINT_ANALYZER_CLASS_FILENAME = 104;
public function getLintNameMap() { public function getLintNameMap() {
return array( return array(
@ -50,8 +49,6 @@ class ArcanistPhutilModuleLinter extends ArcanistLinter {
self::LINT_ANALYZER_NO_INIT => 'Analyzer: No __init__.php File', self::LINT_ANALYZER_NO_INIT => 'Analyzer: No __init__.php File',
self::LINT_ANALYZER_MULTIPLE_CLASSES self::LINT_ANALYZER_MULTIPLE_CLASSES
=> 'Analyzer: File Declares Multiple Classes', => 'Analyzer: File Declares Multiple Classes',
self::LINT_ANALYZER_CLASS_FILENAME
=> 'Analyzer: Filename Does Not Match Class Declaration',
); );
} }