revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 06:42:41 +01:00
Code Issues Releases Wiki Activity

Don't bundle PEP8

Browse source 
Summary: Currently, we bundle a specific version of `pep8` with Arcanist. Whilst maybe this made sense historically, as pointed out by @epriestley in D9412#6, there is no longer much point in doing so.

Test Plan: N/A

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: talshiri, vrusinov, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D9430
This commit is contained in:
Joshua Spence 2015-05-20 07:03:22 +10:00
parent 73feffbe70
commit 5b2571f5ae
3 changed files with 6 additions and 1956 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
externals/pep8/README vendored
View file

@ -1,3 +0,0 @@
pep8.py was written by Johann Rocholl. The main page for the project is here:
https://github.com/jcrocholl/pep8

1942
externals/pep8/pep8.py vendored
View file

File diff suppressed because it is too large Load diff

17
src/lint/linter/ArcanistPEP8Linter.php
View file

@ -40,19 +40,14 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
} }
public function getDefaultBinary() { public function getDefaultBinary() {
if (Filesystem::binaryExists('pep8')) { $prefix = $this->getDeprecatedConfiguration('lint.pep8.prefix');
return 'pep8'; $bin = $this->getDeprecatedConfiguration('lint.pep8.bin', 'pep8');
}
$old_prefix = $this->getDeprecatedConfiguration('lint.pep8.prefix'); if ($prefix) {
$old_bin = $this->getDeprecatedConfiguration('lint.pep8.bin'); return $prefix.'/'.$bin;
if ($old_prefix || $old_bin) { } else {
$old_bin = nonempty($old_bin, 'pep8'); return $bin;
return $old_prefix.'/'.$old_bin;
} }
$arc_root = dirname(phutil_get_library_root('arcanist'));
return $arc_root.'/externals/pep8/pep8.py';
} }
public function getVersion() { public function getVersion() {