mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-09 16:32:39 +01:00
Don't bundle PEP8
Summary: Currently, we bundle a specific version of `pep8` with Arcanist. Whilst maybe this made sense historically, as pointed out by @epriestley in D9412#6, there is no longer much point in doing so. Test Plan: N/A Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: talshiri, vrusinov, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D9430
This commit is contained in:
parent
73feffbe70
commit
5b2571f5ae
3 changed files with 6 additions and 1956 deletions
3
externals/pep8/README
vendored
3
externals/pep8/README
vendored
|
@ -1,3 +0,0 @@
|
||||||
pep8.py was written by Johann Rocholl. The main page for the project is here:
|
|
||||||
|
|
||||||
https://github.com/jcrocholl/pep8
|
|
1942
externals/pep8/pep8.py
vendored
1942
externals/pep8/pep8.py
vendored
File diff suppressed because it is too large
Load diff
|
@ -40,19 +40,14 @@ final class ArcanistPEP8Linter extends ArcanistExternalLinter {
|
||||||
}
|
}
|
||||||
|
|
||||||
public function getDefaultBinary() {
|
public function getDefaultBinary() {
|
||||||
if (Filesystem::binaryExists('pep8')) {
|
$prefix = $this->getDeprecatedConfiguration('lint.pep8.prefix');
|
||||||
return 'pep8';
|
$bin = $this->getDeprecatedConfiguration('lint.pep8.bin', 'pep8');
|
||||||
}
|
|
||||||
|
|
||||||
$old_prefix = $this->getDeprecatedConfiguration('lint.pep8.prefix');
|
if ($prefix) {
|
||||||
$old_bin = $this->getDeprecatedConfiguration('lint.pep8.bin');
|
return $prefix.'/'.$bin;
|
||||||
if ($old_prefix || $old_bin) {
|
} else {
|
||||||
$old_bin = nonempty($old_bin, 'pep8');
|
return $bin;
|
||||||
return $old_prefix.'/'.$old_bin;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
$arc_root = dirname(phutil_get_library_root('arcanist'));
|
|
||||||
return $arc_root.'/externals/pep8/pep8.py';
|
|
||||||
}
|
}
|
||||||
|
|
||||||
public function getVersion() {
|
public function getVersion() {
|
||||||
|
|
Loading…
Reference in a new issue