mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-10 00:42:40 +01:00
(stable) Promote 2021 Week 11
This commit is contained in:
commit
5d9e971ab0
3 changed files with 37 additions and 2 deletions
|
@ -18,7 +18,7 @@ final class PhutilMissingSymbolException extends Exception {
|
|||
'moved, your library map may need to be rebuilt. You can rebuild '.
|
||||
'the map by running "arc liberate".'.
|
||||
"\n\n".
|
||||
'For more information, see: https://phurl.io/newclasses',
|
||||
'For more information, see: https://phurl.io/u/newclasses',
|
||||
$symbol,
|
||||
$type,
|
||||
$reason);
|
||||
|
|
|
@ -19,7 +19,7 @@ final class PhutilJSON extends Phobject {
|
|||
* @param dict An object to encode in JSON.
|
||||
* @return string Pretty-printed object representation.
|
||||
*/
|
||||
public function encodeFormatted(array $object) {
|
||||
public function encodeFormatted($object) {
|
||||
return $this->encodeFormattedObject($object, 0)."\n";
|
||||
}
|
||||
|
||||
|
@ -47,6 +47,10 @@ final class PhutilJSON extends Phobject {
|
|||
* @task internal
|
||||
*/
|
||||
private function encodeFormattedObject($object, $depth) {
|
||||
if ($object instanceof stdClass) {
|
||||
$object = (array)$object;
|
||||
}
|
||||
|
||||
if (empty($object)) {
|
||||
return '{}';
|
||||
}
|
||||
|
@ -123,6 +127,8 @@ final class PhutilJSON extends Phobject {
|
|||
} else {
|
||||
return $this->encodeFormattedObject($value, $depth);
|
||||
}
|
||||
} else if (is_object($value)) {
|
||||
return $this->encodeFormattedObject($value, $depth);
|
||||
} else {
|
||||
if (defined('JSON_UNESCAPED_SLASHES')) {
|
||||
// If we have a new enough version of PHP, disable escaping of slashes
|
||||
|
|
|
@ -18,4 +18,33 @@ EOJSON;
|
|||
pht('Empty arrays should serialize as `%s`, not `%s`.', '[]', '{}'));
|
||||
}
|
||||
|
||||
public function testNestedObjectEncoding() {
|
||||
$expect = <<<EOJSON
|
||||
{
|
||||
"empty-object": {},
|
||||
"pair-object": {
|
||||
"duck": "quack"
|
||||
}
|
||||
}
|
||||
|
||||
EOJSON;
|
||||
|
||||
$empty_object = new stdClass();
|
||||
|
||||
$pair_object = new stdClass();
|
||||
$pair_object->duck = 'quack';
|
||||
|
||||
$input = (object)array(
|
||||
'empty-object' => $empty_object,
|
||||
'pair-object' => $pair_object,
|
||||
);
|
||||
|
||||
$serializer = new PhutilJSON();
|
||||
|
||||
$this->assertEqual(
|
||||
$expect,
|
||||
$serializer->encodeFormatted($input),
|
||||
pht('Serialization of PHP-object JSON values.'));
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue