From 5e4f9a2bf9d2f6f8c8118bfb4d56256d5da13449 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Thu, 23 Jul 2015 09:09:33 +1000 Subject: [PATCH] Fix checkstyle severities Summary: "Advice" is not a valid severity for Checkstyle... valid severities are `ignore`, `info`, `warning` and `error`. Test Plan: Read the [[http://checkstyle.sourceforge.net/property_types.html | documentation]]. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13684 --- .../ArcanistCheckstyleXMLLintRenderer.php | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php b/src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php index b4705ad5..32091bf5 100644 --- a/src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php +++ b/src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php @@ -31,7 +31,7 @@ final class ArcanistCheckstyleXMLLintRenderer extends ArcanistLintRenderer { $this->writer->writeAttribute('line', $message->getLine()); $this->writer->writeAttribute('column', $message->getChar()); $this->writer->writeAttribute('severity', - ArcanistLintSeverity::getStringForSeverity($message->getSeverity())); + $this->getStringForSeverity($message->getSeverity())); $this->writer->writeAttribute('message', $message->getDescription()); $this->writer->writeAttribute('source', $message->getCode()); @@ -52,4 +52,19 @@ final class ArcanistCheckstyleXMLLintRenderer extends ArcanistLintRenderer { return $this->writer->flush(); } + private function getStringForSeverity($severity) { + switch ($severity) { + case ArcanistLintSeverity::SEVERITY_ADVICE: + return 'info'; + case ArcanistLintSeverity::SEVERITY_AUTOFIX: + return 'info'; + case ArcanistLintSeverity::SEVERITY_WARNING: + return 'warning'; + case ArcanistLintSeverity::SEVERITY_ERROR: + return 'error'; + case ArcanistLintSeverity::SEVERITY_DISABLED: + return 'ignore'; + } + } + }