From 5eb82c8e7d6dbe8b60d3da3ac04fcfd4472b9f3a Mon Sep 17 00:00:00 2001 From: Firehed Date: Tue, 20 Aug 2013 06:58:02 -0700 Subject: [PATCH] fix issue where multi-line dataproviders in phpunit were parsed incorrectly when displaying results Summary: Found an issue where if arc unit runs phpunit and the datasets included a dataprovider which spanned multiple lines, it wasn't filtered out correctly in the result parser, this fixes it Test Plan: accidentally ran tests against phpunit itself which exhibits this problem. no longer a problem after this fix, nothing else breaks. Reviewers: epriestley Reviewed By: epriestley CC: aurelijus, epriestley, aran Differential Revision: https://secure.phabricator.com/D6773 --- src/unit/engine/PhpunitResultParser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/unit/engine/PhpunitResultParser.php b/src/unit/engine/PhpunitResultParser.php index 934c48e0..146ba6d2 100644 --- a/src/unit/engine/PhpunitResultParser.php +++ b/src/unit/engine/PhpunitResultParser.php @@ -62,7 +62,7 @@ final class PhpunitResultParser extends ArcanistBaseTestResultParser { } } - $name = preg_replace('/ \(.*\)/', '', $event->test); + $name = preg_replace('/ \(.*\)/s', '', $event->test); $result = new ArcanistUnitTestResult(); $result->setName($name);