From 5fcf7b5a3b9ebbb42130b25f165283dbe2476f0c Mon Sep 17 00:00:00 2001
From: Lukas Sparrow <lukas.sparrow@gmail.com>
Date: Fri, 24 Jul 2015 05:11:32 -0700
Subject: [PATCH] Add $projectRoot to PytestTestEngine

Summary:
Fixes T8912. Property `$project_root` was missing in `PytestTestEngine` class, resulting in
broken py.test wrapper. Also renaming the property so the linter is happy.

Test Plan: `arc unit --everything`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: kparal, epriestley, Korvin

Maniphest Tasks: T8912

Differential Revision: https://secure.phabricator.com/D13698
---
 src/unit/engine/PytestTestEngine.php | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/unit/engine/PytestTestEngine.php b/src/unit/engine/PytestTestEngine.php
index e5fa7370..49ef3c48 100644
--- a/src/unit/engine/PytestTestEngine.php
+++ b/src/unit/engine/PytestTestEngine.php
@@ -5,9 +5,11 @@
  */
 final class PytestTestEngine extends ArcanistUnitTestEngine {
 
+  private $projectRoot;
+
   public function run() {
     $working_copy = $this->getWorkingCopy();
-    $this->project_root = $working_copy->getProjectRoot();
+    $this->projectRoot = $working_copy->getProjectRoot();
 
     $junit_tmp = new TempFile();
     $cover_tmp = new TempFile();
@@ -25,7 +27,7 @@ final class PytestTestEngine extends ArcanistUnitTestEngine {
     }
 
     $future = new ExecFuture('coverage xml -o %s', $cover_tmp);
-    $future->setCWD($this->project_root);
+    $future->setCWD($this->projectRoot);
     $future->resolvex();
 
     return $this->parseTestResults($junit_tmp, $cover_tmp);
@@ -39,7 +41,7 @@ final class PytestTestEngine extends ArcanistUnitTestEngine {
     if ($this->getEnableCoverage() !== false) {
       $cmd_line = csprintf(
         'coverage run --source %s -m %C',
-        $this->project_root,
+        $this->projectRoot,
         $cmd_line);
     }