revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2025-01-24 13:38:18 +01:00
Code Issues Releases Wiki Activity

ArcanistGitAPI: replace 'ls-files -m' with diff-files

Browse source 
As documented,

  $ git ls-files -m

fails to exclude ignored submodules. Replace it with an equivalent:

  $ git diff-files --name-only

which does not suffer from this defect.

See: <https://github.com/facebook/arcanist/pull/121>

Reviewed by: epriestley
This commit is contained in:
Ramkumar Ramachandra 2013-11-22 21:47:15 +05:30 • committed by epriestley
parent e62b23e67d
commit 6033f14221
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/repository/api/ArcanistGitAPI.php
View file

@ -474,11 +474,9 @@ final class ArcanistGitAPI extends ArcanistRepositoryAPI {
)); ));
// Unstaged changes // Unstaged changes
// TODO: This doesn't exclude ignored submodules.
// Upstream bug: http://thread.gmane.org/gmane.comp.version-control.git/238173
$unstaged_future = $this->buildLocalFuture( $unstaged_future = $this->buildLocalFuture(
array( array(
'ls-files -m', 'diff-files --name-only',
)); ));
$futures = array( $futures = array(