From 6082b89eb49c0f3182728a7b7c05c00c900e3918 Mon Sep 17 00:00:00 2001
From: epriestley <epriestley@phabricator.com>
Date: Wed, 9 Feb 2011 09:12:21 -0800
Subject: [PATCH] Use the '(?P<' syntax instead of '(?<' for capturing named
 subgroups.

---
 src/parser/diff/ArcanistDiffParser.php | 34 +++++++++++++-------------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/parser/diff/ArcanistDiffParser.php b/src/parser/diff/ArcanistDiffParser.php
index cbc92087..fec00d3e 100644
--- a/src/parser/diff/ArcanistDiffParser.php
+++ b/src/parser/diff/ArcanistDiffParser.php
@@ -176,18 +176,18 @@ class ArcanistDiffParser {
     do {
       $patterns = array(
         // This is a normal SVN text change, probably from "svn diff".
-        '(?<type>Index): (?<cur>.+)',
+        '(?P<type>Index): (?P<cur>.+)',
         // This is an SVN property change, probably from "svn diff".
-        '(?<type>Property changes on): (?<cur>.+)',
+        '(?P<type>Property changes on): (?P<cur>.+)',
         // This is a git commit message, probably from "git show".
-        '(?<type>commit) (?<hash>[a-f0-9]+)',
+        '(?P<type>commit) (?P<hash>[a-f0-9]+)',
         // This is a git diff, probably from "git show" or "git diff".
-        '(?<type>diff --git) a/(?<old>.+) b/(?<cur>.+)',
+        '(?P<type>diff --git) a/(?P<old>.+) b/(?P<cur>.+)',
         // This is a unified diff, probably from "diff -u" or synthetic diffing.
-        '(?<type>---) (?<old>.+)\s+\d{4}-\d{2}-\d{2}.*',
-        '(?<binary>Binary) files '.
-          '(?<old>.+)\s+\d{4}-\d{2}-\d{2} and '.
-          '(?<new>.+)\s+\d{4}-\d{2}-\d{2} differ.*',
+        '(?P<type>---) (?P<old>.+)\s+\d{4}-\d{2}-\d{2}.*',
+        '(?P<binary>Binary) files '.
+          '(?P<old>.+)\s+\d{4}-\d{2}-\d{2} and '.
+          '(?P<new>.+)\s+\d{4}-\d{2}-\d{2} differ.*',
       );
 
       $ok = false;
@@ -419,17 +419,17 @@ class ArcanistDiffParser {
       do {
 
         $patterns = array(
-          '(?<new>new) file mode (?<newmode>\d+)',
-          '(?<deleted>deleted) file mode (?<oldmode>\d+)',
+          '(?P<new>new) file mode (?P<newmode>\d+)',
+          '(?P<deleted>deleted) file mode (?P<oldmode>\d+)',
           // These occur when someone uses `chmod` on a file.
-          'old mode (?<oldmode>\d+)',
-          'new mode (?<newmode>\d+)',
+          'old mode (?P<oldmode>\d+)',
+          'new mode (?P<newmode>\d+)',
           // These occur when you `mv` a file and git figures it out.
           'similarity index ',
-          'rename from (?<old>.*)',
-          '(?<move>rename) to (?<cur>.*)',
-          'copy from (?<old>.*)',
-          '(?<copy>copy) to (?<cur>.*)'
+          'rename from (?P<old>.*)',
+          '(?P<move>rename) to (?P<cur>.*)',
+          'copy from (?P<old>.*)',
+          '(?P<copy>copy) to (?P<cur>.*)'
         );
 
         $ok = false;
@@ -576,7 +576,7 @@ class ArcanistDiffParser {
     $line = $this->getLine();
     $matches = null;
     $ok = preg_match(
-      '@^[-+]{3} (?:[ab]/)?(?<path>.*?)(?:\s*\(.*\))?$@',
+      '@^[-+]{3} (?:[ab]/)?(?P<path>.*?)(?:\s*\(.*\))?$@',
       $line,
       $matches);
     if (!$ok) {