revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Change "any" to explicitly list revision control systems

Browse source 
Summary: Using `array('any')` to represent `array('git', 'hg', 'svn')` is a bit magical and leads to a lot of special-casing.

Test Plan: Verified that tab completion (ala `ArcanistShellCompleteWorkflow`) still worked.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11604
This commit is contained in:
Joshua Spence 2015-02-02 18:18:36 +11:00
parent 8cad12034f
commit 623df14ae5
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/workflow/ArcanistShellCompleteWorkflow.php
View file

@ -82,10 +82,7 @@ EOTEXT
continue; continue;
} }
$supported = $workflow->getSupportedRevisionControlSystems(); if (!in_array($vcs, $workflow->getSupportedRevisionControlSystems())) {
$ok = (in_array('any', $supported) || in_array($vcs, $supported));
if (!$ok) {
continue; continue;
} }

2
src/workflow/ArcanistWorkflow.php
View file

@ -1216,7 +1216,7 @@ abstract class ArcanistWorkflow extends Phobject {
} }
protected function getSupportedRevisionControlSystems() { protected function getSupportedRevisionControlSystems() {
return array('any'); return array('git', 'hg', 'svn');
} }
final protected function getPassthruArgumentsAsMap($command) { final protected function getPassthruArgumentsAsMap($command) {