From 6270dd0de5073931f3c3e75ab77f0f1d5fa77eef Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 25 Sep 2013 15:26:38 -0700 Subject: [PATCH] Add `https.blindly-trust-domains` to Arcanist Summary: This allows users to specify that they want to implicitly trust their weird self-signed certificate without verification. This can either be specified per user (which will make it apply every time the user runs `arc`, in any project): arc set-config https.blindly-trust-domains '["example.mycompany.com"]' ...or added to a `.arcconfig` file (which will make it apply to every user who runs `arc` in that project): "https.blindly-trust-domains" : ["example.mycompany.com"] Depends on D7130. Test Plan: Tweaked config and verified this setting sends HTTPSFuture down the right branch. Reviewers: btrahan Reviewed By: btrahan CC: hlau, aran Differential Revision: https://secure.phabricator.com/D7131 --- scripts/arcanist.php | 6 ++++++ src/configuration/ArcanistSettings.php | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/scripts/arcanist.php b/scripts/arcanist.php index 0374f78f..63aaf939 100755 --- a/scripts/arcanist.php +++ b/scripts/arcanist.php @@ -208,6 +208,12 @@ try { HTTPSFuture::setGlobalCABundleFromPath($ca_bundle); } + $blind_key = 'https.blindly-trust-domains'; + $blind_trust = $working_copy->getConfigFromAnySource($blind_key); + if ($blind_trust) { + HTTPSFuture::setBlindlyTrustDomains($blind_trust); + } + if ($need_conduit) { if (!$conduit_uri) { diff --git a/src/configuration/ArcanistSettings.php b/src/configuration/ArcanistSettings.php index da9167c6..3fcf573c 100644 --- a/src/configuration/ArcanistSettings.php +++ b/src/configuration/ArcanistSettings.php @@ -103,6 +103,12 @@ final class ArcanistSettings { "behind https signed by your organization's internal CA.", 'example' => 'support/yourca.pem' ), + 'https.blindly-trust-domains' => array( + 'type' => 'list', + 'help' => 'List of domains to blindly trust SSL certificates for. '. + 'Disables peer verification.', + 'example' => '["secure.mycompany.com"]', + ), 'browser' => array( 'type' => 'string', 'help' =>