diff --git a/.arcconfig b/.arcconfig index a2748677..5c31439a 100644 --- a/.arcconfig +++ b/.arcconfig @@ -1,8 +1,8 @@ { "project_id" : "arcanist", "conduit_uri" : "https://secure.phabricator.com/", - "lint_engine" : "ComprehensiveLintEngine", - "unit_engine" : "PhutilUnitTestEngine", + "lint.engine" : "PhutilLintEngine", + "unit.engine" : "PhutilUnitTestEngine", "copyright_holder" : "Facebook, Inc.", "phutil_libraries" : { "arcanist" : "src/" diff --git a/src/lint/engine/PhutilLintEngine.php b/src/lint/engine/PhutilLintEngine.php index d1742978..b4e099fe 100644 --- a/src/lint/engine/PhutilLintEngine.php +++ b/src/lint/engine/PhutilLintEngine.php @@ -94,6 +94,8 @@ class PhutilLintEngine extends ArcanistLintEngine { => ArcanistLintSeverity::SEVERITY_ERROR, ArcanistXHPASTLinter::LINT_PHP_54_FEATURES => ArcanistLintSeverity::SEVERITY_ERROR, + ArcanistXHPASTLinter::LINT_PHT_WITH_DYNAMIC_STRING + => ArcanistLintSeverity::SEVERITY_WARNING, ArcanistXHPASTLinter::LINT_COMMENT_SPACING => ArcanistLintSeverity::SEVERITY_ERROR, )); diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php index aff6f290..07b6bc2e 100644 --- a/src/lint/linter/ArcanistXHPASTLinter.php +++ b/src/lint/linter/ArcanistXHPASTLinter.php @@ -128,7 +128,7 @@ final class ArcanistXHPASTLinter extends ArcanistLinter { self::LINT_IMPLICIT_FALLTHROUGH => ArcanistLintSeverity::SEVERITY_WARNING, self::LINT_PHT_WITH_DYNAMIC_STRING - => ArcanistLintSeverity::SEVERITY_WARNING, + => ArcanistLintSeverity::SEVERITY_DISABLED, self::LINT_SLOWNESS => ArcanistLintSeverity::SEVERITY_WARNING, diff --git a/src/lint/linter/__tests__/xhpast/pht.lint-test b/src/lint/linter/__tests__/xhpast/pht.lint-test index 69b25a44..b9b1c711 100644 --- a/src/lint/linter/__tests__/xhpast/pht.lint-test +++ b/src/lint/linter/__tests__/xhpast/pht.lint-test @@ -7,5 +7,5 @@ pht(); pht($a); pht('%s', $a); ~~~~~~~~~~ -warning:5:1 -warning:7:1 +disabled:5:1 +disabled:7:1