revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-22 14:52:40 +01:00
Code Issues Releases Wiki Activity

Undumb other generic text linters

Browse source 
Summary:
Make all the broad-spectrum text linters use the new binary check.

I didn't touch `ComprehensiveLintEngine` because it's a nest of vipers and no one has complained; see T2039.

Test Plan: Ran `arc lint` on text files and binaries in a libphutil project (arcanist).

Reviewers: lisp

Reviewed By: lisp

CC: aran

Differential Revision: https://secure.phabricator.com/D5040
This commit is contained in:
epriestley 2013-02-20 14:36:53 -08:00
parent 92a5803d30
commit 652472d059
5 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/lint/engine/PhutilLintEngine.php
View file

@ -40,11 +40,10 @@ class PhutilLintEngine extends ArcanistLintEngine {
} }
} }
$text_paths = preg_grep('/\.(php|css|js|hpp|cpp|l|y)$/', $paths); $linters[] = id(new ArcanistGeneratedLinter())->setPaths($paths);
$linters[] = id(new ArcanistGeneratedLinter())->setPaths($text_paths); $linters[] = id(new ArcanistNoLintLinter())->setPaths($paths);
$linters[] = id(new ArcanistNoLintLinter())->setPaths($text_paths); $linters[] = id(new ArcanistTextLinter())->setPaths($paths);
$linters[] = id(new ArcanistTextLinter())->setPaths($text_paths); $linters[] = id(new ArcanistSpellingLinter())->setPaths($paths);
$linters[] = id(new ArcanistSpellingLinter())->setPaths($text_paths);
$php_paths = preg_grep('/\.php$/', $paths); $php_paths = preg_grep('/\.php$/', $paths);

4
src/lint/linter/ArcanistGeneratedLinter.php
View file

@ -25,6 +25,10 @@ final class ArcanistGeneratedLinter extends ArcanistLinter {
} }
public function lintPath($path) { public function lintPath($path) {
if ($this->isBinaryFile($path)) {
return;
}
$data = $this->getData($path); $data = $this->getData($path);
if (preg_match('/@'.'generated/', $data)) { if (preg_match('/@'.'generated/', $data)) {

4
src/lint/linter/ArcanistNoLintLinter.php
View file

@ -25,6 +25,10 @@ final class ArcanistNoLintLinter extends ArcanistLinter {
} }
public function lintPath($path) { public function lintPath($path) {
if ($this->isBinaryFile($path)) {
return;
}
$data = $this->getData($path); $data = $this->getData($path);
if (preg_match('/@'.'nolint/', $data)) { if (preg_match('/@'.'nolint/', $data)) {

4
src/lint/linter/ArcanistSpellingLinter.php
View file

@ -71,6 +71,10 @@ final class ArcanistSpellingLinter extends ArcanistLinter {
} }
public function lintPath($path) { public function lintPath($path) {
if ($this->isBinaryFile($path)) {
return;
}
foreach ($this->partialWordRules as $severity => $wordlist) { foreach ($this->partialWordRules as $severity => $wordlist) {
if ($severity >= $this->severity) { if ($severity >= $this->severity) {
if (!$this->isCodeEnabled($severity)) { if (!$this->isCodeEnabled($severity)) {

4
src/lint/linter/ArcanistTextLinter.php
View file

@ -50,6 +50,10 @@ final class ArcanistTextLinter extends ArcanistLinter {
} }
public function lintPath($path) { public function lintPath($path) {
if ($this->isBinaryFile($path)) {
return;
}
if (!strlen($this->getData($path))) { if (!strlen($this->getData($path))) {
// If the file is empty, don't bother; particularly, don't require // If the file is empty, don't bother; particularly, don't require
// the user to add a newline. // the user to add a newline.