revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-26 00:32:41 +01:00
Code Issues Releases Wiki Activity

Reuse code in close-revision workflow

Browse source 
Test Plan: Will test it by closing this revision.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4122
This commit is contained in:
vrana 2012-12-07 18:02:09 -08:00
parent c43d627cf2
commit 65e3583235
1 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/workflow/ArcanistCloseRevisionWorkflow.php
View file

@ -115,19 +115,12 @@ EOTEXT
$actually_close = true; $actually_close = true;
if ($is_finalize) { if ($is_finalize) {
$project_id = $this->getWorkingCopy()->getProjectID(); $project_info = $this->getProjectInfo();
if ($project_id) { if (idx($project_info, 'tracked') ||
$project_info = $conduit->callMethodSynchronous(
'arcanist.projectinfo',
array(
'name' => $project_id,
));
if ($project_info['tracked'] ||
$revision['status'] != $status_accepted) { $revision['status'] != $status_accepted) {
$actually_close = false; $actually_close = false;
} }
} }
}
if ($actually_close) { if ($actually_close) {
$revision_name = $revision['title']; $revision_name = $revision['title'];