diff --git a/src/unit/__tests__/ArcanistUnitTestResultTestCase.php b/src/unit/__tests__/ArcanistUnitTestResultTestCase.php index 7c4d43dd..7458af8f 100644 --- a/src/unit/__tests__/ArcanistUnitTestResultTestCase.php +++ b/src/unit/__tests__/ArcanistUnitTestResultTestCase.php @@ -40,4 +40,17 @@ final class ArcanistUnitTestResultTestCase extends PhutilTestCase { } } + public function testRenderer() { + $result = new ArcanistUnitTestResult(); + $result->setName('RendererTest'); + $result->setResult('pass'); + $result->setDuration(0.001); + $result->setUserData(''); + + $renderer = new ArcanistUnitConsoleRenderer(); + $output = $renderer->renderUnitResult($result); + $test_dscr = 'Renderer copes with null namespace'; + $this->assertTrue((bool)preg_match('/PASS/', $output), $test_dscr); + } + } diff --git a/src/unit/renderer/ArcanistUnitConsoleRenderer.php b/src/unit/renderer/ArcanistUnitConsoleRenderer.php index 729c4b8d..48a1d96f 100644 --- a/src/unit/renderer/ArcanistUnitConsoleRenderer.php +++ b/src/unit/renderer/ArcanistUnitConsoleRenderer.php @@ -12,7 +12,7 @@ final class ArcanistUnitConsoleRenderer extends ArcanistUnitRenderer { $test_name = $result->getName(); $test_namespace = $result->getNamespace(); - if (strlen($test_namespace)) { + if (phutil_nonempty_string($test_namespace)) { $test_name = $test_namespace.'::'.$test_name; }