revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-11-25 16:22:42 +01:00
Code Issues Releases Wiki Activity

Fix an issue where 'arc alias' reverses parameters

Browse source 
Summary:
We shove alias parameters onto the front of the arg list so if you make an alias like "qdiff" = "diff x y z" and then run "qdiff a b c", we end up with "diff x y z a b c". However, currently we reverse alias parameters, so you actually get "diff z y x a b c".

This is a problem for `arc alias bdiff -- diff --background 1`, which evaluates to `arc diff 1 --background` and fails.

Test Plan: Created a `bdiff` alias and ran it successfully.

Reviewers: vrana, btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3196
This commit is contained in:
epriestley 2012-08-08 12:58:27 -07:00
parent 1ea9b8b02c
commit 678efa44c6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/workflow/ArcanistAliasWorkflow.php
View file

@ -171,7 +171,7 @@ EOTEXT
} }
$alias_argv = array_slice($aliases[$command], 1); $alias_argv = array_slice($aliases[$command], 1);
foreach ($alias_argv as $alias_arg) { foreach (array_reverse($alias_argv) as $alias_arg) {
if (!in_array($alias_arg, $argv)) { if (!in_array($alias_arg, $argv)) {
array_unshift($argv, $alias_arg); array_unshift($argv, $alias_arg);
} }