From 6832afc30026064e9bee3ac09b8b852c3ba4a323 Mon Sep 17 00:00:00 2001 From: Aviv Eyal Date: Sat, 12 Aug 2023 08:43:26 -0700 Subject: [PATCH] Fix jshint tests Summary: The linter's behavior was changed in https://github.com/jshint/jshint/issues/3444: "warnings" are no longer counted for `maxerr`. Updating the test to match... Test Plan: `arc unit src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php` with a recent-ish (2.13.6) jshint. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25355 --- src/lint/linter/__tests__/jshint/too-many-errors.lint-test | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lint/linter/__tests__/jshint/too-many-errors.lint-test b/src/lint/linter/__tests__/jshint/too-many-errors.lint-test index e7b936dd..bc33c0dd 100644 --- a/src/lint/linter/__tests__/jshint/too-many-errors.lint-test +++ b/src/lint/linter/__tests__/jshint/too-many-errors.lint-test @@ -1,5 +1,6 @@ /* jshint maxerr: 1 */ -console.log('foobar') +console.log( +{ ~~~~~~~~~~ -disabled:2:22:E043 -warning:2:22:W033 +disabled:3:1:E043 +error:3:1:E019