revi-archive/phorge-arcanist
1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-23 22:10:54 +01:00
Code Issues Releases Wiki Activity

Allow an arc test to execute without a git author configured

Browse source 
Summary:
On `sbuild`, we currently get a failure on this test. Use an explicit `--author` so we can run the test even if `user.email` and `user.name` are not set in global Git config.

```
   FAIL  ArcanistBundleTestCase::testGitRepository
15	EXCEPTION (CommandException): Command failed with error #128!
16	COMMAND
17	git commit -m 'Mark koan2 +x and edit it.'
18
19	STDOUT
20	(empty)
21
22	STDERR
23
24	*** Please tell me who you are.
25
26	Run
27
28	  git config --global user.email "you@example.com"
29	  git config --global user.name "Your Name"
30
31	to set your account's default identity.
32	Omit --global to set the identity only in this repository.
33
34	fatal: empty ident name (for <builder@sbuild001.phacility.net>) not allowed
```

Test Plan: Ran `arc unit --everything`. Will verify in production.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14232
This commit is contained in:
epriestley 2015-10-04 08:41:48 -07:00
parent 1b4a3e0c5e
commit 6966be3e7e
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/parser/__tests__/ArcanistBundleTestCase.php
View file

@ -137,7 +137,9 @@ final class ArcanistBundleTestCase extends PhutilTestCase {
throw $ex; throw $ex;
} }
execx('git commit -m %s', $subject); $author = 'unit-test <unit-test@phabricator.com>';
execx('git commit --author %s -m %s', $author, $subject);
list($result_hash) = execx('git log -n1 --format=%s', '%T'); list($result_hash) = execx('git log -n1 --format=%s', '%T');
$result_hash = trim($result_hash); $result_hash = trim($result_hash);