mirror of
https://we.phorge.it/source/arcanist.git
synced 2024-11-12 18:02:39 +01:00
Fix a couple of warnings raised by HipHop.
Summary: Test Plan: Reviewers: CC:
This commit is contained in:
parent
cc8c7d4997
commit
6b2c8c6bbb
2 changed files with 8 additions and 3 deletions
|
@ -198,6 +198,11 @@ foreach (Futures($futures) as $file => $future) {
|
||||||
// TODO?: String literal in array literal in call_user_func /
|
// TODO?: String literal in array literal in call_user_func /
|
||||||
// call_user_func_array().
|
// call_user_func_array().
|
||||||
|
|
||||||
|
// TODO: Raise a soft warning for use of an unknown class in:
|
||||||
|
// - Typehints
|
||||||
|
// - instanceof
|
||||||
|
// - catch
|
||||||
|
|
||||||
$classes = $root->selectDescendantsOfType('n_CLASS_DECLARATION');
|
$classes = $root->selectDescendantsOfType('n_CLASS_DECLARATION');
|
||||||
foreach ($classes as $class) {
|
foreach ($classes as $class) {
|
||||||
$class_name = $class->getChildByIndex(1);
|
$class_name = $class->getChildByIndex(1);
|
||||||
|
|
|
@ -692,7 +692,7 @@ EOTEXT
|
||||||
private function getGitUpdateMessage() {
|
private function getGitUpdateMessage() {
|
||||||
$repository_api = $this->getRepositoryAPI();
|
$repository_api = $this->getRepositoryAPI();
|
||||||
|
|
||||||
$parser = new ArcanistDiffParser($repository_api);
|
$parser = new ArcanistDiffParser();
|
||||||
$commit_messages = $repository_api->getGitCommitLog();
|
$commit_messages = $repository_api->getGitCommitLog();
|
||||||
$commit_messages = $parser->parseDiff($commit_messages);
|
$commit_messages = $parser->parseDiff($commit_messages);
|
||||||
|
|
||||||
|
@ -710,7 +710,7 @@ EOTEXT
|
||||||
$conduit = $this->getConduit();
|
$conduit = $this->getConduit();
|
||||||
$repository_api = $this->getRepositoryAPI();
|
$repository_api = $this->getRepositoryAPI();
|
||||||
|
|
||||||
$parser = new ArcanistDiffParser($repository_api);
|
$parser = new ArcanistDiffParser();
|
||||||
$commit_messages = $repository_api->getGitCommitLog();
|
$commit_messages = $repository_api->getGitCommitLog();
|
||||||
$commit_messages = $parser->parseDiff($commit_messages);
|
$commit_messages = $parser->parseDiff($commit_messages);
|
||||||
|
|
||||||
|
@ -814,7 +814,7 @@ EOTEXT
|
||||||
$conduit = $this->getConduit();
|
$conduit = $this->getConduit();
|
||||||
$repository_api = $this->getRepositoryAPI();
|
$repository_api = $this->getRepositoryAPI();
|
||||||
|
|
||||||
$parser = new ArcanistDiffParser($repository_api);
|
$parser = new ArcanistDiffParser();
|
||||||
$history_messages = $repository_api->getGitHistoryLog();
|
$history_messages = $repository_api->getGitHistoryLog();
|
||||||
if (!$history_messages) {
|
if (!$history_messages) {
|
||||||
// This can occur on the initial commit.
|
// This can occur on the initial commit.
|
||||||
|
|
Loading…
Reference in a new issue