From 6cd3d8e995705231ab6e04affbb945da1f13fad6 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Thu, 31 Jan 2013 12:21:26 -0800
Subject: [PATCH] Fix getting changed files in SVN

Summary:
This is pretty awkward but I don't have anything better.

Also don't compute cache key if caching is disabled.

Test Plan:
  $ svn diff --xml --summarize '' -r 701319:HEAD
  $ svn diff --xml --summarize svn+ssh://tubbs/svnroot/projects/lolbunny -r 701319:HEAD

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4771
---
 src/repository/api/ArcanistSubversionAPI.php | 10 ++++++++--
 src/workflow/ArcanistLintWorkflow.php        |  5 ++++-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/repository/api/ArcanistSubversionAPI.php b/src/repository/api/ArcanistSubversionAPI.php
index 672cd13e..f247b238 100644
--- a/src/repository/api/ArcanistSubversionAPI.php
+++ b/src/repository/api/ArcanistSubversionAPI.php
@@ -494,10 +494,16 @@ EODIFF;
   }
 
   public function getChangedFiles($since_commit) {
+    $url = '';
+    $match = null;
+    if (preg_match('/(.*)@(.*)/', $since_commit, $match)) {
+      list(, $url, $since_commit) = $match;
+    }
     // TODO: Handle paths with newlines.
     list($stdout) = $this->execxLocal(
-      '--xml diff --revision %s:HEAD --summarize',
-      $since_commit);
+      '--xml diff --revision %s:HEAD --summarize %s',
+      $since_commit,
+      $url);
     $xml = new SimpleXMLElement($stdout);
 
     $return = array();
diff --git a/src/workflow/ArcanistLintWorkflow.php b/src/workflow/ArcanistLintWorkflow.php
index c1c1fc69..1f3cd213 100644
--- a/src/workflow/ArcanistLintWorkflow.php
+++ b/src/workflow/ArcanistLintWorkflow.php
@@ -195,7 +195,10 @@ EOTEXT
     $engine = newv($engine, array());
     $this->engine = $engine;
     $engine->setWorkingCopy($working_copy);
-    $engine->setRepositoryVersion($this->getRepositoryVersion());
+
+    if ($use_cache) {
+      $engine->setRepositoryVersion($this->getRepositoryVersion());
+    }
 
     $engine->setMinimumSeverity(
       $this->getArgument('severity', self::DEFAULT_SEVERITY));