1
0
Fork 0
mirror of https://we.phorge.it/source/arcanist.git synced 2024-12-23 05:50:54 +01:00

Fix additional "xsprintf()"-family static parameter errors

Summary:
Ref T13577. After the lint rule fix in D21453, it can identify more errors. Fix the errors it identifies in "arcanist/".

These all seem fairly obscure/benign.

Test Plan: Ran `arc lint` on the files before and after these changes. Did not specifically re-test these particular messages, but they mostly very obscure.

Maniphest Tasks: T13577

Differential Revision: https://secure.phabricator.com/D21456
This commit is contained in:
epriestley 2020-09-04 17:30:36 -07:00
parent 83e63aeb07
commit 7112ee3d59
6 changed files with 9 additions and 6 deletions

View file

@ -27,7 +27,9 @@ final class ArcanistHardpointList
pht(
'Hardpoint (at index "%s") has the same key ("%s") as an earlier '.
'hardpoint. Each hardpoint must have a key that is unique '.
'among hardpoints on the object.'));
'among hardpoints on the object.',
$idx,
$key));
}
$map[$key] = $hardpoint;

View file

@ -1459,6 +1459,7 @@ abstract class ArcanistLandEngine
'Merge strategy "%s" specified in "%s" configuration is '.
'unknown. Supported merge strategies are: %s.',
$strategy,
$this->getStrategyConfigurationKey(),
$strategy_list));
}

View file

@ -778,7 +778,7 @@ final class ArcanistMercurialAPI extends ArcanistRepositoryAPI {
pht(
"'%s' has been amended with 'Differential Revision:', ".
"as specified by '%s' in your %s 'base' configuration.",
'.'.
'.',
$rule,
$source));
// NOTE: This should be safe because Mercurial doesn't support

View file

@ -553,6 +553,7 @@ final class ArcanistRuntime {
'workflow in a given toolset must have a unique name.',
get_class($workflow),
get_class($map[$key]),
$key,
get_class($toolset),
$toolset->getToolsetKey()));
}

View file

@ -72,8 +72,8 @@ final class ArcanistAliasEngine
pht(
'Configuration source ("%s") defines an invalid alias, which '.
'will be ignored: %s',
$alias->getConfigurationSource()->getSourceDisplayName()),
$exception->getMessage());
$alias->getConfigurationSource()->getSourceDisplayName(),
$exception->getMessage()));
}
$command = array_shift($argv);

View file

@ -35,8 +35,7 @@ EOTEXT
'help' => pht(
"Close only if the repository is untracked and the revision is ".
"accepted. Continue even if the close can't happen. This is a soft ".
"version of '' used by other workflows.",
'close-revision'),
"version of 'close-revision' used by other workflows."),
),
'quiet' => array(
'help' => pht('Do not print a success message.'),